[Bug 210007] Review Request: <libtune> - <standard API to access the kernel tunables>

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: <libtune> - <standard API to access the kernel tunables>


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=210007





------- Additional Comments From konradr at redhat.com  2006-11-20 15:01 EST -------
* I think the need to have in the spec file the build against different kernels
and releases is not needed.

The reason for this is that when I build the package for FC6, I end up with:
[konrad at dhcp83-148 task_394874]$ ls
libtune-0.10-3.i386.rpm                tunables-data-2.6.16-0.10-3.ppc.rpm
libtune-0.10-3.ia64.rpm                tunables-data-2.6.16-0.10-3.s390.rpm
libtune-0.10-3.ppc64.rpm               tunables-data-2.6.16-0.10-3.s390x.rpm
libtune-0.10-3.ppc.rpm                 tunables-data-2.6.16-0.10-3.x86_64.rpm
libtune-0.10-3.s390.rpm                tunables-data-2.6.18-0.10-3.i386.rpm
libtune-0.10-3.s390x.rpm               tunables-data-2.6.18-0.10-3.ia64.rpm
libtune-0.10-3.src.rpm                 tunables-data-2.6.18-0.10-3.ppc64.rpm
libtune-0.10-3.x86_64.rpm              tunables-data-2.6.18-0.10-3.ppc.rpm
libtune-debuginfo-0.10-3.i386.rpm      tunables-data-2.6.18-0.10-3.s390.rpm
libtune-debuginfo-0.10-3.ia64.rpm      tunables-data-2.6.18-0.10-3.s390x.rpm
libtune-debuginfo-0.10-3.ppc64.rpm     tunables-data-2.6.18-0.10-3.x86_64.rpm
libtune-debuginfo-0.10-3.ppc.rpm       tunables-data-FC5-2.6.16-0.10-3.i386.rpm
libtune-debuginfo-0.10-3.s390.rpm      tunables-data-FC5-2.6.16-0.10-3.ia64.rpm
libtune-debuginfo-0.10-3.s390x.rpm     tunables-data-FC5-2.6.16-0.10-3.ppc64.rpm
libtune-debuginfo-0.10-3.x86_64.rpm    tunables-data-FC5-2.6.16-0.10-3.ppc.rpm
libtune-devel-0.10-3.i386.rpm          tunables-data-FC5-2.6.16-0.10-3.s390.rpm
libtune-devel-0.10-3.ia64.rpm          tunables-data-FC5-2.6.16-0.10-3.s390x.rpm
libtune-devel-0.10-3.ppc64.rpm         tunables-data-FC5-2.6.16-0.10-3.x86_64.rpm
libtune-devel-0.10-3.ppc.rpm           tunables-data-FC6-2.6.18-0.10-3.i386.rpm
libtune-devel-0.10-3.s390.rpm          tunables-data-FC6-2.6.18-0.10-3.ia64.rpm
libtune-devel-0.10-3.s390x.rpm         tunables-data-FC6-2.6.18-0.10-3.ppc64.rpm
libtune-devel-0.10-3.x86_64.rpm        tunables-data-FC6-2.6.18-0.10-3.ppc.rpm
logs                                   tunables-data-FC6-2.6.18-0.10-3.s390.rpm
tunables-data-2.6.16-0.10-3.i386.rpm   tunables-data-FC6-2.6.18-0.10-3.s390x.rpm
tunables-data-2.6.16-0.10-3.ia64.rpm   tunables-data-FC6-2.6.18-0.10-3.x86_64.rpm
tunables-data-2.6.16-0.10-3.ppc64.rpm


It is not neccessary to build all those extra tunables-data for different
kernels and releases when I am building just against FC6. The end result should
be just one "tunables-data-<something>.fc6.<platform>" for each platform.
Otherwise the CD with FC6 ends up with RPMs for FC5, which is clearly not needed.

I think it would be better to remove the big loop, use the %dist as part of the
devel package. The kernel number component should be automaticly extracted -
this should be possible if you make the BuildReq depend on kernel-devel. Perhaps
it is not even neccesary to put the kernel version in the name of the RPM, but
just have it as a dependency? 

That would also remove lots hard-coded 2.6.16/2.6.18/FC5/FC6 strings used in the
names.

* The Release tag in the spec file. It should have "%{dist}" post-fix.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.