[Bug 216300] Review Request: chemtool - A program for 2D drawing organic molecules

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: chemtool - A program for 2D drawing organic molecules


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=216300





------- Additional Comments From rpm at greysector.net  2006-11-20 18:49 EST -------
(In reply to comment #11)
> Okay, this time both mockbuild and rpmbuild are okay.
> Then doing the full review.
> 
> 1. From http://fedoraproject.org/wiki/Packaging/Guidelines :
> 
> * Licensing
> - Well, it seems that this package is licensed under GPL according
>   to several source codes, however, many source codes have no
>   licensing terms. Would you ask upstream to clarify the license
>   (or include GPL document to source tarball)? (currently not a
>   blocker).

Mail sent.

> 2. From http://fedoraproject.org/wiki/Packaging/ScriptletSnippets :
> * desktop-database
> - fedora-chemtool.desktop has mimetype keys,
> -------------------------------------------
> MimeType=application/x-chemtool;Application
> -------------------------------------------
>   which requires update-desktop-database.

Done.

> 4. Other things I have noticed:
> - %doc
>   I think %doc examples/ (i.e. include 'example' directory itself)
>   is better than %doc examples/* .

Done.

http://rpm.greysector.net/extras/chemtool.spec
http://rpm.greysector.net/extras/chemtool-1.6.9-5.src.rpm


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.