[Bug 216354] Review Request: liquidwar - Multiplayer wargame with liquid armies

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: liquidwar - Multiplayer wargame with liquid armies


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=216354





------- Additional Comments From wart at kobold.org  2006-11-20 20:59 EST -------
GOOD
====
* Package and spec named appropriately
* GPL license ok, license file included
* Source matches upstream:
  a41473c281f214c1ac96ab50f98537c9  liquidwar-5.6.3.tar.gz
* Spec file legible and in Am. English
* Compiles and builds on (FC5, FC6, devel) x (i386, x86_64)
* No -devel subpackage needed
* Large docs are located in -doc subpackage
* Not relocatable
* No locales
* Directory ownership ok
* file permissions ok
* .desktop file and icons installed correctly
* No shared libraries
* Application runs as expected

SHOULD
======
* Consider adding the README file to %doc.  It contains the address of the
  package's mailing list which doesn't appear elsewhere.

* 'make dep' gets run as part of the build, and generates the following
  harmless warning:
gmake[1]: Entering directory `/space/rpmbuild/BUILD/liquidwar-5.6.3/src'
find: .-name: No such file or directory
find: *.c: No such file or directory
cc: no input files
gmake[1]: Leaving directory `/space/rpmbuild/BUILD/liquidwar-5.6.3/src'
  It seems there is a missing space after the '.' in src/Makefile.in line 256:
        @find .\
        -name '*.c' | \

* The man page refers the reader to "/usr/share/doc/liquidwar" for more
  documentation.  This path should be updated to point to the files in the
  -doc subpackage.

* The URL: tag points to a page with a better home page link:
  http://www.ufoot.org/liquidwar/v5

* The metaserver URL in the man page is wrong.  It should be:
  http://www.ufoot.org/liquidwar/v5/metaserver

* An init.d script for starting a liquidwar server at boot time would be nice. 
Perhaps if I find some extra time I'll write one for you.

None of these issues are serious enough to block approval:

APPROVED


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.