[Bug 210287] Review Request: Qt# - A set of qt bindings for mono
bugzilla at redhat.com
bugzilla at redhat.com
Tue Nov 21 19:39:54 UTC 2006
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: Qt# - A set of qt bindings for mono
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=210287
mtasaka at ioa.s.u-tokyo.ac.jp changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |ASSIGNED
AssignedTo|nobody at fedoraproject.org |mtasaka at ioa.s.u-tokyo.ac.jp
OtherBugsDependingO|163776 |163778
nThis| |
------- Additional Comments From mtasaka at ioa.s.u-tokyo.ac.jp 2006-11-21 14:39 EST -------
Well, actually I don't know about C sharp program,
however, as this package is not reviewed by anyone
for more than one month and it is a pity that this
package is not imported despite you seem familiar with
C sharp programming, so I will try.
Then:
1. http://fedoraproject.org/wiki/Packaging/Guidelines :
* Use rpmlint
- rpmlint is not silent.
----------------------------------------------
E: qtsharp zero-length /usr/share/doc/qtsharp-0.7.1/ChangeLog
W: qtsharp rpm-buildroot-usage %build qmake "CSC=mcs"
INSTALLDIR=%{buildroot}/%{_libdir}
W: qtsharp-devel no-documentation
----------------------------------------------
- Remove ChangeLog.
- I don't think that giving the argument which includes
%{buildroot} during %build stage is correct.
- The last one can be ignorable, I think.
* Requires:
- Requires: qt mono-core
These are unnecessary as libraries' dependency automatically
pulls them.
* Compiler flags
- For compilation of C sharp code, I don't know. Howver,
-------------------------------------------------
make[2]: Entering directory `/builddir/build/BUILD/qtsharp/src/libqtsharp'
g++ -c -pipe -Wall -W -g -D_REENTRANT -fPIC -DQT_THREAD_SUPPORT -DQT_SHARED
-DQT_NO_DEBUG -I/usr/lib/qt-3.3/mkspecs/de
fault -I. -I. -I.. -I/usr/lib/qt-3.3/include -o customslot.o customslot.cpp
g++ -c -pipe -Wall -W -g -D_REENTRANT -fPIC -DQT_THREAD_SUPPORT -DQT_SHARED
-DQT_NO_DEBUG -I/usr/lib/qt-3.3/mkspecs/de
fault -I. -I. -I.. -I/usr/lib/qt-3.3/include -o qtsharp.o qtsharp.cpp
-------------------------------------------------
This is incorrect because fedora specific compilation flags
is not used.
* Parallel make
- Does this package fail on parallel make?
2. From http://fedoraproject.org/wiki/Packaging/ReviewGuidelines :
(seems okay).
3. Other files I have noticed.
* -devel package:
devel package contains only a symlink to shared object, without
any header files. I don't think this devel package is useful
as so application can use this package because there is no way
to know the prototype used in the shared library.
--
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.
More information about the Fedora-package-review
mailing list