[Bug 216755] Review Request: GLiv - OpenGL image viewer
bugzilla at redhat.com
bugzilla at redhat.com
Wed Nov 22 14:24:08 UTC 2006
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: GLiv - OpenGL image viewer
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=216755
------- Additional Comments From mtasaka at ioa.s.u-tokyo.ac.jp 2006-11-22 09:23 EST -------
Well;
1. From http://fedoraproject.org/wiki/Packaging/Guidelines :
* Use rpmlint
- Rpmlint is not silent.
-----------------------------------------------------------
//usr/share/applications/fedora-gliv.desktop: warning:
Categories values must be one of <snip>
(found "Application")
//usr/share/applications/fedora-gliv.desktop: warning:
Categories values must be one of <snip>
(found "X-Red-Hat-Base")
-----------------------------------------------------------
The category 'Application' and 'X-Red-Hat-Base' is no
longer used (since desktop-file-utils 0.11) and this
should be removed.
NOTE: These warnings can be seem only in FC-devel.
* Documentation
-------------------------------
%doc %{_mandir}/man1/gliv.1*
%doc %{_mandir}/*/man1/gliv.1*
------------------------------
- man manual files should not be marked as %doc.
* Why the %makeinstall macro should not be used
- Don't use %makeinstall macro as this is known to be broken.
* Scriptlets requirements:
Please check
http://fedoraproject.org/wiki/Packaging/ScriptletSnippets
* desktop-database
- fedora-gliv.desktop has MimeType and this requires
'update-desktop-database'.
2. From http://fedoraproject.org/wiki/Packaging/ReviewGuidelines :
* The sources .... as provided in the spec URL
--------------------------------------------
[tasaka1 at localhost gliv]$ LANG=C wget -N
http://guichaz.free.fr/gliv/gliv-1.9.6.tar.bz2
--23:19:24-- http://guichaz.free.fr/gliv/gliv-1.9.6.tar.bz2
Resolving guichaz.free.fr... 212.27.63.100
Connecting to guichaz.free.fr|212.27.63.100|:80... connected.
HTTP request sent, awaiting response... 404 Not Found
23:19:25 ERROR 404: Not Found.
--------------------------------------------
--
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.
More information about the Fedora-package-review
mailing list