[Bug 216105] Review Request: python-twisted-web - Twisted web server, programmable in Python

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: python-twisted-web - Twisted web server, programmable in Python


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=216105


paul at city-fan.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|nobody at fedoraproject.org    |paul at city-fan.org
OtherBugsDependingO|163776                      |163778
              nThis|                            |




------- Additional Comments From paul at city-fan.org  2006-11-22 11:44 EST -------
Review
======

- package and spec file naming OK
- package meets guidelines
- license is MIT, matches spec
- spec file written in English and is legible
- sources match upstream
- package builds OK in mock for FC4-Rawhide, i386 and x86_64
- BR's OK
- no locale issues
- no shared libraries
- not relocatable
- no directory ownership or permissions issues
- %clean section present and correct
- macro usage consistent enough
- code, not content
- docs aren't excessively large
- docs don't affect runtime
- no subpackages
- no devel files present
- not a GUI app, no desktop file needed
- package seems to work OK (tested with bittorrent 5.0.1)

MUSTFIX:

* Include LICENSE as %doc

PROBLEM:

# rpm -qa python-twisted\*
python-twisted-web-0.6.0-4.fc6
python-twisted-core-2.4.0-4.fc6
# rpm -e python-twisted-web
Traceback (most recent call last):
  File "/usr/libexec/twisted-dropin-cache", line 16, in ?
    list(getPlugins(IPlugin))
--- <exception caught here> ---
  File "/usr/lib64/python2.4/site-packages/twisted/plugin.py", line 214, in
getPlugins
    adapted = interface(plugin, None)
  File "/usr/lib64/python2.4/site-packages/zope/interface/interface.py", line
658, in __call__
    adapter = conform(self)
  File "/usr/lib64/python2.4/site-packages/twisted/plugin.py", line 77, in
__conform__
    return self.load()
  File "/usr/lib64/python2.4/site-packages/twisted/plugin.py", line 72, in load
    return namedAny(self.dropin.moduleName + '.' + self.name)
  File "/usr/lib64/python2.4/site-packages/twisted/python/reflect.py", line 370,
in namedAny
    obj = getattr(obj, n)
exceptions.AttributeError: 'module' object has no attribute 'twisted_web'

I think that needs fixing.

NOTES:

* rpmlint output:
E: python-twisted-web no-binary
  This is to be expected for what is essentially a noarch package that has to
  live in an arch-specific place due to the way python works, i.e. not an issue

SUGGESTIONS:

* URL should be: http://twistedmatrix.com/trac/wiki/TwistedWeb
* Include NEWS as %doc



-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.