[Bug 216534] Review Request: gocr - GNU Optical Character Recognition program

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: gocr - GNU Optical Character Recognition program


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=216534





------- Additional Comments From pertusus at free.fr  2006-11-22 17:52 EST -------
(In reply to comment #2)

> > There are many Requires missing. At least (in pnm.c), 
> > gzip, bzip2, transfig, netpbm-progs, libjpeg
> 
> I'm wondering whether to make these hard Requires or not.  Obviously you need
> some to get extra functionality, but only for the image types you need to
> process.  Perhaps just a note in the description?

It depends how it fails. But given what those deps are,
except maybe for transfig, I can't see why they couldn't be 
hard requires. png, jpeg, gif and eps support seems to be 
a must to me.

I tested a bit, but I get only segfaults on non pnm files (tried
png and eps):

$ gocr ex.pcx 
Special chars: àá__åæç À Å Æ ß &$Xgo ØØ44t>¢µ
Special chars= àáâãäåæç À Å Æ ß &$XO_o øØ44 _>_µ
Special  chars :  àáâăäåæç À Å _ _  G_#9o 0Ø44>>tµ
$ convert ex.pcx ex.png
$ gocr ex.png 
pngtopnm: warning - non-square pixels; to fix do a 'pamscale -yscale 4.28479'
Erreur de segmentation

$ gdb --args gocr ex.png
....
(gdb) run
Starting program: /usr/bin/gocr ex.png
pngtopnm: warning - non-square pixels; to fix do a 'pamscale -yscale 4.28479'

Program received signal SIGSEGV, Segmentation fault.
0x00aebf18 in pnm_readpaminit () from /usr/lib/libnetpbm.so.10
(gdb) bt
#0  0x00aebf18 in pnm_readpaminit () from /usr/lib/libnetpbm.so.10
#1  0x080a0560 in readpgm (name=0xbfbc6a06 "ex.png", p=0xbfbbc2cc, vvv=0)
    at pnm.c:149
#2  0x080493b9 in main (argn=2, argv=0xbfbc5464) at gocr.c:272
#3  0x0082ce5c in __libc_start_main () from /lib/libc.so.6
#4  0x08048e01 in _start ()



With gziped or bzip2ed files, things are not better:
$ gzip ex.pcx
$ gocr ex.pcx.gz 
ERROR pcx.c L28: no ZSoft sign


Another issue is that in gocr.tcl, the show button seems to
invoke a program which isn't installed. There is an error with

couldn't execute "xli": no such file or directory

similarly with spell

couldn't execute "tkispell": no such file or directory

and with scan it starts xsane, so there is a missing dependency.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.