[Bug 214312] Review Request: xdms - Extracts Amiga DMS archives

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: xdms - Extracts Amiga DMS archives
Alias: xdms

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=214312


chris.stone at gmail.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
OtherBugsDependingO|163778                      |163779
              nThis|                            |




------- Additional Comments From chris.stone at gmail.com  2006-11-23 13:02 EST -------
==== REVIEW CHECKLIST ====
O rpmlint output:
  E: xdms configure-without-libdir-spec

  This is because of a non-standard configure script.  You should place a
comment in the specfile indicating why you cannot set libdir.
- package named according to package naming guidelines
- spec filename matches %{name}
- package meets packaging guidelines
- package licensed as "Public Domain"
  This is not listed in the open source compatible licenses, but I assume it's
valid for Fedora since rpmlint recognizes it.
- License matches actual license, located in source files
- no license in %doc because it just says "Public Domain" in the source files
- spec file written in American english
- spec file is legible
- source match upstream
  f687a5beba88964ef0afd478efe99849  xdms-1.3.2.tar.bz2
- package successfully compiles and builds on FC6 x86_64
- all dependencies listed in BR
- no locales
- no shared libraries
- package is not relocatable
- package owns all directories it creates
- no duplicates in %files
- file permissions set properly
- package has proper %clean section
O macro usage is consistent
  Why not use %{opt_flags} instead of $RPM_OPT_FLAGS since you use %{buildroot}?
- package contains code
- no large documentation
- %doc does not affect runtime
- no header files or static libraries
- no pkgconfig files
- package does not require a devel subpackage
- no .la files
- package is not a GUI app
- package does not own files or directories owned by other packages


** APPROVED **

==== SHOULD ====
- Add comment above configure explaining why you cannot set libdir
- Use %{optflags} instead of $RPM_OPT_FLAGS since you use %{buildroot} instead
of $RPM_BUILD_ROOT. Not really necessary, but more consistent with your usage.


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.