[Bug 216354] Review Request: liquidwar - Multiplayer wargame with liquid armies

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: liquidwar - Multiplayer wargame with liquid armies


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=216354





------- Additional Comments From j.w.r.degoede at hhs.nl  2006-11-23 15:23 EST -------
(In reply to comment #1)
Thanks for review and the good feedback!
> 
> SHOULD
> ======
> * Consider adding the README file to %doc.  It contains the address of the
>   package's mailing list which doesn't appear elsewhere.
> 
Done

> * 'make dep' gets run as part of the build, and generates the following
>   harmless warning:
> gmake[1]: Entering directory `/space/rpmbuild/BUILD/liquidwar-5.6.3/src'
> find: .-name: No such file or directory
> find: *.c: No such file or directory
> cc: no input files
> gmake[1]: Leaving directory `/space/rpmbuild/BUILD/liquidwar-5.6.3/src'
>   It seems there is a missing space after the '.' in src/Makefile.in line 256:
>         @find .\
>         -name '*.c' | \
> 
Harmless indeed, ignored.

> * The man page refers the reader to "/usr/share/doc/liquidwar" for more
>   documentation.  This path should be updated to point to the files in the
>   -doc subpackage.
> 
Fixed

> * The URL: tag points to a page with a better home page link:
>   http://www.ufoot.org/liquidwar/v5
> 
Done

> * The metaserver URL in the man page is wrong.  It should be:
>   http://www.ufoot.org/liquidwar/v5/metaserver
> 
Fixed

> * An init.d script for starting a liquidwar server at boot time would be nice. 
> Perhaps if I find some extra time I'll write one for you.
> 

I wouldn't mind receiving this, together with a patch to split out the server in
its own subpackage, as I think if we add an init script the server really should
be in its own subpackage (and we need to think about wether to start it by
default or not)

> None of these issues are serious enough to block approval:
> 
> APPROVED
> 

Imported and build, closing. Thanks again!


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.