[Bug 211626] Review Request: xtide - Calculate tide all over the world

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: xtide - Calculate tide all over the world


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=211626


pertusus at free.fr changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED




------- Additional Comments From pertusus at free.fr  2006-11-24 04:43 EST -------
I have checked all the packages, everything seems right. Much thanks
to David for changing his packages, now the packaging is much simpler.
Hoping that it also profits to him...
The recursive dependency issue is even sorted out as a side effect
of rearranging the sources, and libtcd should be multilib.

I have spotted those issues:

* I think that libtcd qualifies for keeping the static library
  since it could be used to handle trusted data in numerical
  experiments where compiling statically enhance portability. 
  You can keep it out, as long as you respond favorably to
  users asking to have it back.

*
/usr/libexec/tideEditor-desktop: line 30: [: too many arguments
there is a -or instead of -o

* in the latest line of xtide-README.fedora one should read
/usr/share/xtide-harmonics instead of /usr/share/wvs-data. Also
maybe administer should be changed to administrator.

* tideEditor-desktop may be in %{_bindir} to avoid hardcoding
/usr/lib/libexec in desktop file (since using %{_libexecdir} is 
not easy)

* for the xttpd wrapper it is less easy to use properly the
macro. Maybe a simple 
sed -e 's,/usr/libexec/,%{_libexecdir},' ....
on the script would do the trick.

* there are other hardcoded file path in the -common subpackage, but
these ones are not problematic in my opinion since they are in clearly 
fedora packaging specific parts under our complete control.


Now I think you should submit reviews for each package, I think that
you can reuse your closed tickets or open new ones, at your will.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.