[Bug 216947] Review Request: perl-Gtk2-Notify - Gtk2::Notify Perl module

bugzilla at redhat.com bugzilla at redhat.com
Sat Nov 25 17:44:47 UTC 2006


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: perl-Gtk2-Notify - Gtk2::Notify Perl module


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=216947





------- Additional Comments From panemade at gmail.com  2006-11-25 12:44 EST -------
Till you take time to update new SRPM here comes review
Review:
+ package builds in mock (development i386).
+ rpmlint is silent for SRPM and but NOT for RPMS.
  But those warnings are ignored.
+ source files match upstream.
77a64c944cf1516bcc514456de22a82b  Gtk2-Notify-0.02.tar.gz
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.  License text included in package.
+ %doc is small; no -doc subpackage required.
+ %doc does not affect runtime.
+ BuildRequires are proper.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code, not content.
+ no headers or static libraries.
+ .pc file present.
+ no -devel subpackage exists
+ no .la files.
+ no translations are available
+ Dose owns the directories it creates.
+ no duplicates in %files.
+ file permissions are appropriate.
+ Followed perl packaging guidelines.
APPROVED.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.




More information about the Fedora-package-review mailing list