[Bug 214818] Review Request: audacious - A GTK2 based media player similar to xmms

bugzilla at redhat.com bugzilla at redhat.com
Sat Nov 25 17:45:31 UTC 2006


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: audacious - A GTK2 based media player similar to xmms


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=214818





------- Additional Comments From panemade at gmail.com  2006-11-25 12:45 EST -------
Ok here comes Final Review.
Review:
+ package builds in mock (development i386) for FC6.
+ rpmlint is silent for RPM and SRPM.
+ source files match upstream.
f718f66ec0cab46bf6210d2243d12be1   audacious-1.2.1.tgz
+ package meets naming and packaging guidelines.
+ specfile is properly named and is cleanly written.
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.  License text included in package.
+ %doc is small; no -doc subpackage required.
+ %doc does not affect runtime.
+ COPYING included in %doc.
+ BuildRequires are proper.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code, not content.
+ no headers or static libraries.
+ .pc files present in -devel
+ -devel and -libs subpackage exists
+ no .la files.
+ translations are available.
+ update-desktop-database is used at postun and post
+ called /sbin/ldconfig on libs package.
+ owns the directories it creates.
+ doesn't own any directories it shouldn't.
+ no duplicates in %files.
+ file permissions are appropriate.
+ Desktop file installed successfully
+ Desktop file is handled correctly in SPEC file.
+ GUI application
APPROVED.


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.




More information about the Fedora-package-review mailing list