[Bug 217249] Review Request: atomorun - Jump&Run game where you have to flee an exploding nuclear bomb

bugzilla at redhat.com bugzilla at redhat.com
Sat Nov 25 21:54:13 UTC 2006


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: atomorun - Jump&Run game where you have to flee an exploding nuclear bomb
Alias: atomorun

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=217249





------- Additional Comments From chris.stone at gmail.com  2006-11-25 16:53 EST -------
==== REVIEW CHECKLIST ====
- rpmlint output clean
- package named according to package naming guidelines
- spec file name matches %{name}
- package meets packaging guidelines
- package licensed with open source compatible license
- license matches actual license
- license included in %doc
- spec written in American english
- spec legible
- sources match upstream
41522a330c0da7c6e79c46baa2c1d8c3  atomorun-1.1_pre2.tar.gz
- package successfully compiles and builds on FC6 x86_64
- all build dependencies listed in BR
- no locales
- no shared libraries
- package is not relocatable
- package owns all directories it creates
X package uses a directory which is not pulled in from Requires
- no duplicates in %files
- file permissions set properly
- spec contains proper %clean section
- macro usage is consistent
- package contains code
- no large documentation
- %doc does not affect runtime
- no header files or static libraries
- no pkgconfig files
- no devel subpackage required
- no .la files
- GUI app contains proper .desktop file
- package does not own files or directories owned by other packages


==== MUST FIX ====
- Add Requires: icons-hicolor-theme to pull in icons directory


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.




More information about the Fedora-package-review mailing list