[Bug 217557] Review Request: keurocalc - KEuroCalc is a universal currency converter and calculator

bugzilla at redhat.com bugzilla at redhat.com
Wed Nov 29 05:25:46 UTC 2006


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: keurocalc - KEuroCalc is a universal currency converter and calculator


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=217557





------- Additional Comments From panemade at gmail.com  2006-11-29 00:25 EST -------
Anyways here comes 
Review:
+ package builds in mock (development i386).
+ rpmlint is silent for SRPM and but NOT for RPMS.
  But those warnings can be ignored as said in comment #10.
+ source files match upstream.
d2e22dcbba267549bf3a93ed8bf715c2  keurocalc-0.9.7.tgz
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.  License text included in package.
+ %doc is small; no -doc subpackage required.
+ %doc does not affect runtime.
+ COPYING included in %doc.
+ BuildRequires are proper.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code, not content.
+ no headers or static libraries.
+ no .pc file present.
+ no -devel or any subpackages exists
+ no .la files.
+ no translations are available
+ Dose owns the directories it creates.
+ no duplicates in %files.
+ file permissions are appropriate.
+ Desktop files are not handled in usual way but its ok.
+ Used properly gtk-update-icon-cache scriptlet


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.




More information about the Fedora-package-review mailing list