[Bug 211433] Review Request: wdm - WINGs Display Manager

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: wdm - WINGs Display Manager


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=211433





------- Additional Comments From pertusus at free.fr  2006-11-29 04:33 EST -------
(In reply to comment #7)

Most should be ignorable.

> W: wdm dangling-relative-symlink /etc/wdm/GiveConsole ../X11/xdm/GiveConsole
> W: wdm dangling-relative-symlink /etc/wdm/Xaccess ../X11/xdm/Xaccess
> W: wdm dangling-relative-symlink /etc/wdm/Xsetup_0 ../X11/xdm/Xsetup_0
> W: wdm dangling-relative-symlink /etc/wdm/TakeConsole ../X11/xdm/TakeConsole

Symlinks to xdm scripts to avoid duplicating, and also because
they are more recent and maintained as part of xdm.

> E: wdm executable-marked-as-config-file /etc/wdm/Xsession

That's a session script, rightly located in /etc/

> E: wdm non-standard-dir-perm /etc/wdm/authdir 0700

restricted permissions for a directory holding sensitive files.

> E: wdm non-executable-script /etc/wdm/Xsession.orig 0644
> E: wdm executable-marked-as-config-file /etc/wdm/TakeConsole.wdm
> E: wdm executable-marked-as-config-file /etc/wdm/Xsetup_0.wdm
> E: wdm executable-marked-as-config-file /etc/wdm/GiveConsole.wdm
> E: wdm executable-marked-as-config-file /etc/wdm/Xsession.wdm
> E: wdm executable-marked-as-config-file /etc/wdm/Xsession.XFree86

Other session scripts. They could be in %doc, but I think that 
it is better to have them right in the config dir, such that it is 
easy to switch to them. Xsession.orig is not set executable upstream,
it is the original X11R? session script. After reading Xsession.orig
and Xsession.XFree86, it seems like they use /tmp insecurely, so 
I'll remove them. Xsession.wdm too, uses /tmp insecurely but I'll 
patch it.

> W: wdm strange-permission wdm-update_wdm_wmlist 0755

This is a script so executable.

> E: wdm wrong-script-interpreter /etc/wdm/Xclients.in "@SHELL_LOGIN@"
> E: wdm non-executable-script /etc/wdm/Xclients.in 0644
> E: wdm executable-marked-as-config-file /etc/wdm/Xclients

/etc/wdm/Xclients is a session script, and it can be regenerated
from Xclients.in using wdmReconfig, it explains the rpmlint errors.
It is also not used in the default case, but provided for those
who want to use the config from upstream.



This one is to be fixed:
> E: wdm script-without-shebang /etc/wdm/Xsession

I will fix that one.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.