[Bug 209608] Review Request: dwdiff - Front end to diff for comparing files on a word per word basis
bugzilla at redhat.com
bugzilla at redhat.com
Fri Oct 6 18:36:13 UTC 2006
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: dwdiff - Front end to diff for comparing files on a word per word basis
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=209608
tmraz at redhat.com changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|ASSIGNED |NEEDINFO
Flag| |needinfo?(jhrozek at redhat.com
| |)
------- Additional Comments From tmraz at redhat.com 2006-10-06 14:36 EST -------
GOOD: No rpmlint warnings or errors.
BAD: Use full url on Source0
BAD: Use either $RPM_BUILD_ROOT + $RPM_OPT_FLAGS or the macros, not both.
BAD: See packaging guidelines how to use %find_lang to package the localizations.
It should Requires diffutils.
It must BuildRequires at least gettext and diffutils (as diff is checked by the
configure program)
Next time read http://fedoraproject.org/wiki/Packaging/Guidelines
--
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.
More information about the Fedora-package-review
mailing list