[Bug 207782] Review Request: itpp - C++ library for math, signal/speech processing, and communications

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: itpp - C++ library for math, signal/speech processing, and communications


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=207782


mtasaka at ioa.s.u-tokyo.ac.jp changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
OtherBugsDependingO|163778                      |163779
              nThis|                            |




------- Additional Comments From mtasaka at ioa.s.u-tokyo.ac.jp  2006-10-12 14:04 EST -------
(In reply to comment #47)
> Yes, but is it a _blocker_ for this review?
> 
> The points I'm trying to make are that 
> (1) I'm rather confident that it 
> works safely and correctly as it is currently packaged in -7, 

It is true.

> (2) I'm 
> not 100% certain that what you suggest will work in all cases [how can 
> we be certain?] 

As I explained, since linkage is now correct and header files are
"consistent", the external linkage should not be necessary.

> (3) what you suggest is a further deviation from 
> the way upstream does things and therefore it should be done cautiously.

Well, please report this argument to upstream. Anyway it is recommended
(I think) that the maintainer in Fedora and upstream has good connection.

> So, I prefer to leave it as-is.

Okay. Then for now I don't block this any longer.

----------------------------------------------------------------------------------------
   This package (itpp) is now APPROVED by me.



-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.