[Bug 193867] Review Request: klamav - Clam Anti-Virus on the KDE Desktop

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: klamav - Clam Anti-Virus on the KDE Desktop


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=193867





------- Additional Comments From cgoorah at yahoo.com.au  2006-09-02 06:16 EST -------
**** The "Update Process died unexpectedly! Did you kill it manually?" bug and
solution

chitlesh(~)[0]$pkgs=`rpm -qa | grep clam`; echo $pkgs; rpm -V $pkgs
clamav-data-0.88.4-1.fc5 clamav-lib-0.88.4-1.fc5 clamav-0.88.4-1.fc5
clamav-devel-0.88.4-1.fc5

chitlesh(~)[0]$klamav
/bin/bash: freshclam: command not found
QLayout "unnamed" added to Klamav "KlamAV ", which already has a layout
/bin/bash: freshclam: command not found

I was missing clamav-update
Add clamav-update as Requires.


* rpmlint issues

chitlesh(~)[0]$rpmlint /home/chitlesh/rpmbuild/RPMS/i386/klamav-0.38-1.i386.rpm
W: klamav dangling-symlink /usr/share/doc/HTML/en/klamav02/common
/usr/share/doc/HTML/en/common
W: klamav symlink-should-be-relative /usr/share/doc/HTML/en/klamav02/common
/usr/share/doc/HTML/en/common
W: klamav non-executable-in-bin /usr/bin/ScanWithKlamAV 0644
E: klamav non-executable-script /usr/bin/ScanWithKlamAV 0644

chitlesh(~)[0]$rpmlint
/home/chitlesh/rpmbuild/RPMS/i386/klamav-debuginfo-0.38-1.i386.rpm
E: klamav-debuginfo script-without-shellbang
/usr/src/debug/klamav-0.38/src/klammail/client.c
E: klamav-debuginfo script-without-shellbang
/usr/src/debug/klamav-0.38/src/klammail/options.c
E: klamav-debuginfo script-without-shellbang
/usr/src/debug/klamav-0.38/src/klammail/options.h
E: klamav-debuginfo script-without-shellbang
/usr/src/debug/klamav-0.38/src/klammail/clamdmail.c
E: klamav-debuginfo script-without-shellbang
/usr/src/debug/klamav-0.38/src/klammail/treewalk.c

chitlesh(~)[0]$rpmlint /home/chitlesh/rpmbuild/SRPMS/klamav-0.38-1.src.rpm
chitlesh(~)[0]$                                                               

You should check rpmlint on all your *.rpm

**** Using %{buildroot} and %{optflags} vs  $RPM_BUILD_ROOT and $RPM_OPT_FLAGS
- Mixed use is found. Please unify the usage.

You could use 
%{__rm} -rf %{buildroot}
instead of
%{__rm} -rf "${RPM_BUILD_ROOT}"


**** Correct and update the spec file and srpm, i'll check them again

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.