[Bug 204525] Review Request: eclipse-gef - Eclipse Graphical Editing Framework

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: eclipse-gef - Eclipse Graphical Editing Framework


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=204525





------- Additional Comments From green at redhat.com  2006-09-02 13:14 EST -------
More on rpmlint output...

========= eclipse-gef-3.2.0-2.i386.rpm
W: eclipse-gef non-standard-group Text Editors/Integrated Development
Environments (IDE)

The other IDEs in Fedora Extras use "Development/Tools".  On the other hand, 
eclipse-gef isn't really an IDE or a tool, it's just a library that can also be
used for RCP apps and not just within Eclipse.  I recommend changing this to
"System Environment/Libraries", since that's all this really is.  

W: eclipse-gef invalid-license Eclipse Public License - v 1.0 (EPL)
<http://www.eclipse.org/legal/epl-v10.html>

Please just change this to "Eclipse Public License".  We don't put URLs here.

W: eclipse-gef no-documentation

The packaging rules say...
"If (and only if) the source package includes the text of the license(s) in its
own file, then that file, containing the text of the license(s) for the package
must be included in %doc."

I realize that Eclipse & friends install license somewhere else by default, but
we should really put a copy in this directory as well as per the packaging
guidelines.  Eventually this should be done for all Eclipse packages.  I think
maybe only one or two do this today.

========= eclipse-gef-examples-3.2.0-2.i386.rpm
W: eclipse-gef-examples non-standard-group Text Editors/Integrated Development
Environments (IDE)
W: eclipse-gef-examples invalid-license Eclipse Public License - v 1.0 (EPL)
<http://www.eclipse.org/legal/epl-v10.html>

As above.

========= eclipse-gef-sdk-3.2.0-2.i386.rpm
W: eclipse-gef-sdk non-standard-group Text Editors/Integrated Development
Environments (IDE)

I think this should be "Documentation".

W: eclipse-gef-sdk invalid-license Eclipse Public License - v 1.0 (EPL)
<http://www.eclipse.org/legal/epl-v10.html>

As above.

W: eclipse-gef-sdk no-documentation

I think this is ignoreable.

========= eclipse-gef-3.2.0-2.src.rpm
W: eclipse-gef non-standard-group Text Editors/Integrated Development
Environments (IDE)
W: eclipse-gef invalid-license Eclipse Public License - v 1.0 (EPL)
<http://www.eclipse.org/legal/epl-v10.html>

As above.

W: eclipse-gef mixed-use-of-spaces-and-tabs

Just run emacs untabify on the spec file before building.







-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.