[Bug 202006] Review Request: fmio - FM radio card manipulation utility

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: fmio - FM radio card manipulation utility


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=202006


kevin at tummy.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|bugzilla-sink at leemhuis.info |kevin at tummy.com
OtherBugsDependingO|163776                      |163778
              nThis|                            |




------- Additional Comments From kevin at tummy.com  2006-09-02 13:54 EST -------
OK - Package name
OK - Spec file matches base package name.
OK - Meets Packaging Guidelines.
OK - License (BSD)
OK - License field in spec matches
See below - License file included in package
OK - Spec in American English
OK - Spec is legible.
OK - Sources match upstream md5sum:
3eb91258db51e7ab78e2d4a8c2c31037  fmio-2.0.8.tar.gz
3eb91258db51e7ab78e2d4a8c2c31037  fmio-2.0.8.tar.gz.1
fe74b5965f6a27b1d91d481705a926d0  fmio-gq-wrapper.py
fe74b5965f6a27b1d91d481705a926d0  fmio-gq-wrapper.py.1
OK - Package compiles and builds on at least one arch.
OK - BuildRequires correct
OK - Spec has needed ldconfig in post and postun
OK - Package owns all the directories it creates.
OK - Package has no duplicate files in %files.
OK - Package has %defattr and permissions on files is good.
OK - Package has a correct %clean section.
OK - Spec has consistant macro usage.
OK - Package is code or permissible content.
OK - Packages %doc files don't affect runtime.
OK - Headers/static libs in -devel subpackage.
See below - .so files in -devel subpackage.
OK - -devel package Requires: %{name} = %{version}-%{release}
OK - Package doesn't own any directories other packages own.
See below - No rpmlint output.
SHOULD Items:
See below - Should include License or ask upstream to include it.
OK - Should build in mock.

Issues:

1. Might see if the upstream could include a copy of the license
with the package (although development seems pretty stalled).
Any chance of upstream taking any of your patches and doing a new
release?

2. You use %makeinstall, can you change to
make install DESTDIR=%{buildroot}
See:
http://www.fedoraproject.org/wiki/Packaging/Guidelines#head-
fcaf3e6fcbd51194a5d0dbcfbdd2fcb7791dd002

3. rpmlint says:
W: fmio unstripped-binary-or-object /usr/lib/libradio.so
Permissions are wrong on that file. It's 644, but should be
755?
W: fmio no-soname /usr/lib/libradio.so
This would be good to fix, but might be a pretty big patch.
W: fmio strange-permission fmio-gq-wrapper.py 0755
This can probibly be ignored.
W: fmio mixed-use-of-spaces-and-tabs
This would be good to fix. Use either spaces or tabs in the spec.
W: fmio-devel no-documentation
Can be ignored.
W: fmio-wmfmio non-conffile-in-etc /etc/wmfmiorc
Should mark that file as %config ?


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.