[Bug 205029] Review Request: autobuild-applet - a GNOME applet for monitoring Test-AutoBuild build status

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: autobuild-applet - a GNOME applet for monitoring Test-AutoBuild build status


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=205029





------- Additional Comments From bdpepple at ameritech.net  2006-09-02 15:52 EST -------
Couple of quick items:

1. Desktop file is incorrectly handled.  Refer to
http://fedoraproject.org/wiki/Packaging/Guidelines#head-254ddf07aae20a23ced8cecc219d8f73926e9755
2. Duplicate BuildRequires: gtk2-devel (provided by libgnomeui-devel)
3. Unnecessary Requires: python, libgnome, libgnomeui. sonames from devel
packages should pull these in.
4. Missing necessary requires on GConf for schemas installation, and probably
should use the standard gconf scriptlets for FE packages.  Refer to
http://fedoraproject.org/wiki/Packaging/ScriptletSnippets?action=show&redirect=ScriptletSnippets#head-6c2101d8f810cc95c677c8c27f43573b0bc23cb1


Minor:
1. Preferred buildroot.
http://fedoraproject.org/wiki/Packaging/Guidelines#head-f196e7b2477c2f5dd97ef64e8eacddfb517f1aa1

If I get some free time this weekend I'll try to do a more formal review.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.