[Bug 205030] Review Request: atomix - Little mind game where you have to build molecules out of atoms lying around
bugzilla at redhat.com
bugzilla at redhat.com
Sat Sep 2 20:27:45 UTC 2006
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: atomix - Little mind game where you have to build molecules out of atoms lying around
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=205030
------- Additional Comments From paul at all-the-johnsons.co.uk 2006-09-02 16:27 EST -------
Okay, give #4
Review
------
Good :
Spec file readable and in US English
No ownership problems with directories
No devel package (so that bit can be ignored!)
Upstream md5sum = package md5sum
Builds cleanly in mock (i386)
No dupes in rpms
Package includes documentation
Correctly creates it's own localdir instead of polluting
Consistent use of macros
Uses dist and smp_flags
Software actually works
No suprious permissions in the rpms
Needs work
Needs to include find-lang
Once the needs work has been attended to, I'm happy for this to go in.
--
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.
More information about the Fedora-package-review
mailing list