[Bug 199168] Review Request: CGAL

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: CGAL
Alias: CGAL

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=199168





------- Additional Comments From ed at eh3.com  2006-09-03 22:40 EST -------
Hi Laurent, I'm sorry for the delay.  Heres a more formal review.

good:
 + naming guidelines OK
 + source matches upstream
 + builds in in FC6-i386 mock OK
 + license files are correctly included
 + spec is legible and appears sane
 + shared libs OK
 + dir ownership looks OK
 + %clean is OK
 + macro use looks OK
 + code not content OK
 + proper use of devel
 + no *.la files

needswork:
 - license should say QPL/LGPL and not QPL/GPL
 - the description in /usr/share/doc/CGAL-3.2.1/README.Fedora is no
   longer accurate since the CGAL-libs package was removed

comments / not-sure:
 - Typically, packages are not supposed to include "private" versions of
   3-rd party packages.  Instead, the 3-rd party bits should be made into
   their own separate packages and then used as build- and/or run-time
   dependencies.  At least theoretically, the CORE bits should be a
   separate package.  Looking at the CORE web site:

     http://cs.nyu.edu/exact/core/download/prerelease/

   it appears that CORE does not receive frequent updates.  The last
   release was in 2004.  So one could perhaps argue that the CGAL
   upstream is effectively acting as maintainers for CORE.  Is that the
   case?  If so, I think it could stay as-is provided there are no
   naming conflicts or other problems.
 - Could all the *.vcproj files be deleted?  I don't see any reason
   why folks would want them on a Fedora system.

rpmlint reports:
  E: CGAL-devel file-in-usr-marked-as-conffile /usr/share/CGAL/make/makefile
  W: CGAL-devel non-conffile-in-etc /etc/profile.d/cgal.sh
  E: CGAL-devel script-without-shellbang /etc/profile.d/cgal.sh
  E: CGAL-devel non-executable-script /etc/profile.d/cgal.sh 0644
  W: CGAL-devel non-conffile-in-etc /etc/profile.d/cgal.csh
  E: CGAL-devel script-without-shellbang /etc/profile.d/cgal.csh
  E: CGAL-devel non-executable-script /etc/profile.d/cgal.csh 0644
 which are all probably safe to ignore

I'm tempted to approve this package conditional on the two needswork items
being fixed.

Does anyone else have any objections or suggestions?  If there are no
negative comments in 2--3 days, I'll send an approval message.


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.