[Bug 204125] Review Request: tremulous-data - Data files for tremulous the FPS game

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: tremulous-data - Data files for tremulous the FPS game


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=204125





------- Additional Comments From matthias at rpmforge.net  2006-09-04 11:55 EST -------
Preliminary comments :

This notice seems like a leftover from a copy/paste of the main spec file :
# this is basicly
# http://dl.sourceforge.net/tremulous/tremulous-%{version}.zip
# repackaged with tremulous-%{version}-src.tar.gz  removed as that contains
# non Free software (the lcc compiler).

- Why do you hardcode the name and more importantly the version in the Source0
line? This can lead to the typical case where you increase the "Verrsion:" line
but forget the Source0 one and the resulting package seems to be the new version
when it's still the old ;-) Some people prefer like that, but in the main
tremulous package you use %{version}.
- The cp %{SOURCE1} fedora-copyright.txt should be replaced by "install -p -m
0644 %{SOURCE1} fedora-copyright.txt" since a wrong umask could lead to a world
writeable file, like it has already happened in the Extras build system...
- I'd suggest removing the %{?dist} from the release since this data can and
should be shared across all releases (i.e. packages copied as-is for FC-5 and FC-6).
- The %description should end with a dot :-)

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.