[Bug 204121] Review Request: tremulous - First Person Shooter game based on the Quake 3 engine

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: tremulous - First Person Shooter game based on the Quake 3 engine


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=204121





------- Additional Comments From j.w.r.degoede at hhs.nl  2006-09-04 14:33 EST -------
(In reply to comment #1)
> Preliminary comments :
> - I would rename the tarball to something different from upstream in order to
> make it impossible to get both confused, ever. Something like
> %{name}-%{version}-src-nolcc.tar.gz maybe?
Done

> - The desktop file needs tremulous.xpm changed to tremulous.png
Fixed

> - You have -m64 in the BASE_CFLAGS set by your patch (probably unwanted even
> though the spec file overrides it)
Hmm, that probably is a left over from your or Warts sed s/// approach to fixing
the CFLAGS, its really harmless as it the affected part of the makefile only
gets used on SunOS :)

Anyways I've pruned this and a few other unneeded changes from the patch.

> - Matthias takes two T's (%changelog) :-)
Oops, fixed

Here is a new version with all this fixed:
Spec URL: http://people.atrpms.net/~hdegoede/tremulous.spec
SRPM URL: http://people.atrpms.net/~hdegoede/tremulous-1.1.0-2.src.rpm


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.