[Bug 190029] Review Request: whysynth-dssi - DSSI software synthesizer plugin

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: whysynth-dssi - DSSI software synthesizer plugin


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=190029





------- Additional Comments From green at redhat.com  2006-09-04 18:28 EST -------
(In reply to comment #4)
> Here are some comments from me:
> 
> rpmlint shows some errors:
> 
> W: whysynth-dssi incoherent-version-in-changelog 0.1.3-3 20060122-3.fc5
> 
> last changelog entry mentions version 0.1.3-3 but the package is 20060122-3, 
> the other entries may have the wrong version, too.

Fixed

> W: whysynth-dssi dangling-symlink /usr/bin/whysynth /usr/bin/jack-dssi-host
> 
> Don't know, what this means.

This is OK.  It's a symlink to something that isn't in this RPM.
 
> W: whysynth-dssi 
> symlink-should-be-relative /usr/bin/whysynth /usr/bin/jack-dssi-host
> 
> Make sure, the symlink is relative.

Fixed.

> W: whysynth-dssi macro-in-%changelog __rm
> W: whysynth-dssi macro-in-%changelog makeinstall
> 
> Macros mentioned in %changelog must be escaped with an %, e.g. %%{__rm} 
> instead of %{__rm}

Fixed.
 
> Package builds in mock, but there are some warnigs in the build log:

I'm ignoring these for now.  Tweaking compile options may possibly result in
better performance.

Spec URL: http://people.redhat.com/green/FE/FC5/whysynth-dssi.spec
SRPM URL: http://people.redhat.com/green/FE/FC5/whysynth-dssi-20060122-3.src.rpm




-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.