[Bug 197740] Review Request: dircproxy - IRC proxy server

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: dircproxy - IRC proxy server


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=197740


jwilson at redhat.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEEDINFO                    |ASSIGNED
               Flag|needinfo?(jwilson at redhat.com|
                   |)                           |




------- Additional Comments From jwilson at redhat.com  2006-09-06 00:40 EST -------
(In reply to comment #7)
> Whew!  ok :)

I know that feeling... Been a bit overloaded with other stuff, finally getting back to this...

> 1. It appears to me that this proxy can be run as a non-root user and still be
> able to do everything needed except use the "switch_user" command.  (Read
> another way, it looks like you only need to run dircproxy as root if you want
> to use "switch_user".)  Let's find a way to have this service start up as a
> non-root user by default (perhaps just "nobody" as README.identd suggests).

Won't work as nobody:

# su nobody -c "/usr/bin/dircproxy -f /etc/dircproxyrc"
This account is currently not available.

I'll have to add an account w/a valid login shell, but that's easy enough.

> It would seem to make sense to patch /etc/init.d/dircproxy to read values from
> /etc/sysconf/dircproxy (as other init scripts do) to determine what user to
> run under, etc.

Will do.

> 2. The release tag here, as this is a beta package, should be something like:
> 
>     0.x.beta%{?dist}

Fixed locally.

> 3. rpmlint emits two warnings -- both of these are easy enough to fix.
[...]
> [build at zeus dircproxy]$ rpmlint dircproxy-1.2.0-0.beta.1.fc5.src.rpm
> W: dircproxy mixed-use-of-spaces-and-tabs
> [build at zeus x86_64]$ rpmlint dircproxy-1.2.0-0.beta.1.fc5.x86_64.rpm
> W: dircproxy wrong-file-end-of-line-encoding

Both fixed locally.

Just need to fix up the bits to run as non-root, which I'll have to save for tomorrow...

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.