[Bug 204525] Review Request: eclipse-gef - Eclipse Graphical Editing Framework

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: eclipse-gef - Eclipse Graphical Editing Framework


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=204525


overholt at redhat.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEEDINFO                    |ASSIGNED




------- Additional Comments From overholt at redhat.com  2006-09-06 14:19 EST -------
(In reply to comment #5)
> I recommend changing this to
> "System Environment/Libraries", since that's all this really is.  

Done.

> W: eclipse-gef invalid-license Eclipse Public License - v 1.0 (EPL)
> <http://www.eclipse.org/legal/epl-v10.html>
> 
> Please just change this to "Eclipse Public License".  We don't put URLs here.

Done.

> W: eclipse-gef no-documentation
> 
> The packaging rules say...
> "If (and only if) the source package includes the text of the license(s) in its
> own file, then that file, containing the text of the license(s) for the package
> must be included in %doc."
> 
> I realize that Eclipse & friends install license somewhere else by default, but
> we should really put a copy in this directory as well as per the packaging
> guidelines.  Eventually this should be done for all Eclipse packages.  I think
> maybe only one or two do this today.

Okay, I've added the epl to a GEF-owned directory.

> ========= eclipse-gef-examples-3.2.0-2.i386.rpm
> W: eclipse-gef-examples non-standard-group Text Editors/Integrated Development
> Environments (IDE)
> W: eclipse-gef-examples invalid-license Eclipse Public License - v 1.0 (EPL)
> <http://www.eclipse.org/legal/epl-v10.html>
> 
> As above.

Done.

> ========= eclipse-gef-sdk-3.2.0-2.i386.rpm
> W: eclipse-gef-sdk non-standard-group Text Editors/Integrated Development
> Environments (IDE)
> 
> I think this should be "Documentation".

I'm not sure I agree with this as it contains source plugins as well but I've
done it :)

> W: eclipse-gef-sdk invalid-license Eclipse Public License - v 1.0 (EPL)
> <http://www.eclipse.org/legal/epl-v10.html>
> 
> As above.

Done.

> W: eclipse-gef-sdk no-documentation
> 
> I think this is ignoreable.
> 
> ========= eclipse-gef-3.2.0-2.src.rpm
> W: eclipse-gef non-standard-group Text Editors/Integrated Development
> Environments (IDE)
> W: eclipse-gef invalid-license Eclipse Public License - v 1.0 (EPL)
> <http://www.eclipse.org/legal/epl-v10.html>
> 
> As above.

Yup.

> W: eclipse-gef mixed-use-of-spaces-and-tabs
> 
> Just run emacs untabify on the spec file before building.

Fixed.  I get no output from rpmlint when I run it.

Updated spec URL: http://people.redhat.com/~overholt/eclipse-gef.spec
Updated SRPM URL: http://people.redhat.com/~overholt/eclipse-gef-3.2.0-2.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.