[Bug 205059] Review Request: perl-POE-Filter-Zlib - POE filter wrapped around Compress::Zlib
bugzilla at redhat.com
bugzilla at redhat.com
Wed Sep 6 18:34:26 UTC 2006
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: perl-POE-Filter-Zlib - POE filter wrapped around Compress::Zlib
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=205059
tibbs at math.uh.edu changed:
What |Removed |Added
----------------------------------------------------------------------------
OtherBugsDependingO|163778 |163779
nThis| |
------- Additional Comments From tibbs at math.uh.edu 2006-09-06 14:34 EST -------
329825354 Perl modules on the Wall...
Note that 1.5 came out just before you submitted this, but I don't think that's
a blocker. Too bad he still won't include any information on the licensing of
his modules.
* source files match upstream:
ee3c93a09f4640bd42a5781375a48082 POE-Filter-Zlib-1.4.tar.gz
* package meets naming and packaging guidelines.
* specfile is properly named, is cleanly written and uses macros consistently.
* dist tag is present.
* build root is correct.
* license field matches the actual license.
* license is open source-compatible. Correspondence clarifying the license is
included.
X latest version is being packaged.
* BuildRequires are proper.
* %clean is present.
* package builds in mock (development, x86_64).
* rpmlint is silent.
* final provides and requires are sane:
perl(POE::Filter::Zlib) = 1.4
perl(POE::Filter::Zlib::Stream) = 1.4
perl-POE-Filter-Zlib = 1.4-1.fc6
=
perl(:MODULE_COMPAT_5.8.8)
perl(Carp)
perl(Compress::Zlib)
perl(POE::Filter)
perl(base)
perl(vars)
* %check is present and all tests pass:
All tests successful.
Files=3, Tests=13, 0 wallclock secs ( 0.10 cusr + 0.04 csys = 0.14 CPU)
* package is not relocatable.
* owns the directories it creates.
* doesn't own any directories it shouldn't.
* no duplicates in %files.
* file permissions are appropriate.
* no scriptlets present.
* code, not content.
* documentation is small, so no -docs subpackage is necessary.
* %docs are not necessary for the proper functioning of the package.
* no headers.
* no pkgconfig files.
* no libtool .la droppings.
APPROVED
--
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.
More information about the Fedora-package-review
mailing list