[Bug 205062] Review Request: perl-Sub-Install - Install subroutines into packages easily

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: perl-Sub-Install - Install subroutines into packages easily


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=205062


tibbs at math.uh.edu changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
OtherBugsDependingO|163778                      |163779
              nThis|                            |




------- Additional Comments From tibbs at math.uh.edu  2006-09-06 22:55 EST -------
Some tests are skipped due to the lack of Test::Output; thanks for the note.  I
wonder if it would be possible to run all of the tests once the dependencies are
in the repo.  That would mean installing an older version of the module you're
building, which would be odd but should technically be possible.

Anyway, this package is fine:
* source files match upstream:
   48e8e9f72cdd5b3f5f7115b8b7de3ddf  Sub-Install-0.922.tar.gz
* package meets naming and packaging guidelines.
* specfile is properly named, is cleanly written and uses macros consistently.
* dist tag is present.
* build root is correct.
* license field matches the actual license.
* license is open source-compatible.  License text not included upstream.
* latest version is being packaged.
* BuildRequires are proper.
* %clean is present.
* package builds in mock (development, x86_64).
* rpmlint is silent.
* final provides and requires are sane:
   perl(Sub::Install) = 0.922
   perl-Sub-Install = 0.922-1.fc6
  =
   perl(:MODULE_COMPAT_5.8.8)
   perl(Carp)
   perl(Scalar::Util)
   perl(strict)
   perl(warnings)
* %check is present and all tests pass:
   All tests successful, 2 subtests skipped.
   Files=11, Tests=67,  0 wallclock secs ( 0.36 cusr +  0.11 csys =  0.47 CPU)
   (two tests are skipped due to lack of Test::Output)
* package is not relocatable.
* owns the directories it creates.
* doesn't own any directories it shouldn't.
* no duplicates in %files.
* file permissions are appropriate.
* no scriptlets present.
* code, not content.
* documentation is small, so no -docs subpackage is necessary.
* %docs are not necessary for the proper functioning of the package.

APPROVED

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.