[Bug 205309] Review Request: perl-Algorithm-C3 - Module for merging hierarchies using the C3 algorithm

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: perl-Algorithm-C3 - Module for merging hierarchies using the C3 algorithm


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=205309


tibbs at math.uh.edu changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
OtherBugsDependingO|163778                      |163779
              nThis|                            |




------- Additional Comments From tibbs at math.uh.edu  2006-09-06 23:50 EST -------
Sorry to step into this conversation, but I have some time for reviews, so....

* source files match upstream:
   d087e68c937e7076bb07396b281685c1  Algorithm-C3-0.05.tar.gz
* package meets naming and packaging guidelines.
* specfile is properly named, is cleanly written and uses macros consistently.
* dist tag is present.
* build root is correct.
* license field matches the actual license.
* license is open source-compatible.  License text not included upstream.
* latest version is being packaged.
* BuildRequires are proper.
* %clean is present.
* package builds in mock (development, x86_64).
* rpmlint is silent.
* final provides and requires are sane:
   perl(Algorithm::C3) = 0.05
   perl-Algorithm-C3 = 0.05-1.fc6
  =
   perl(:MODULE_COMPAT_5.8.8)
   perl(Carp)
   perl(strict)
   perl(warnings)
* %check is present and all tests pass:
   All tests successful.
   Files=11, Tests=57,  1 wallclock secs ( 0.32 cusr +  0.14 csys =  0.46 CPU)
* package is not relocatable.
* owns the directories it creates.
* doesn't own any directories it shouldn't.
* no duplicates in %files.
* file permissions are appropriate.
* no scriptlets present.
* code, not content.
* documentation is small, so no -docs subpackage is necessary.
* %docs are not necessary for the proper functioning of the package.

APPROVED

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.