[Bug 196843] Review Request: php-pear-Benchmark - PEAR: Framework to benchmark PHP scripts or function calls
bugzilla at redhat.com
bugzilla at redhat.com
Fri Sep 8 01:20:51 UTC 2006
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: php-pear-Benchmark - PEAR: Framework to benchmark PHP scripts or function calls
Alias: php-pear-Benchmark
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=196843
tibbs at math.uh.edu changed:
What |Removed |Added
----------------------------------------------------------------------------
OtherBugsDependingO|163778 |163779
nThis| |
------- Additional Comments From tibbs at math.uh.edu 2006-09-07 21:20 EST -------
* source files match upstream:
b130c602f82ee07af4021a59b6359003 Benchmark-1.2.6.tgz
* package meets naming and packaging guidelines.
* specfile is properly named, is cleanly written and uses macros consistently.
* dist tag is present.
* build root is correct.
* license field matches the actual license.
* license is open source-compatible. License text included in package.
* latest version is being packaged.
* BuildRequires are proper.
* %clean is present.
* package builds in mock (development, x86_64).
* rpmlint is silent (except for bogus dangerous-command-in-%post warning).
* final provides and requires are sane:
php-pear(Benchmark) = 1.2.6
php-pear-Benchmark = 1.2.6-1.fc6
=
/bin/sh
/usr/bin/pear
php-bcmath (note that Requires(hint) is currently the same as Requires)
php-pear(PEAR)
* %check is not present; no test suite upstream.
* package is not relocatable.
* owns the directories it creates.
* doesn't own any directories it shouldn't.
* no duplicates in %files.
* file permissions are appropriate.
* no scriptlets present.
* code, not content.
* documentation is small, so no -docs subpackage is necessary.
* %docs are not necessary for the proper functioning of the package.
APPROVED
--
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.
More information about the Fedora-package-review
mailing list