[Bug 187294] Review Request: gwyddion

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: gwyddion


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=187294





------- Additional Comments From yeti at physics.muni.cz  2006-09-08 06:14 EST -------
(In reply to comment #22)
> Indeed this should be the case, but the gwyddion internal
> modules requires the interpreter, so they should pull it in.

The presence or absence of the interpreters has absolutely no effect of the
function of the main package.  So how it comes it requires it?

It starts having an effect only after you add something else -- that however
requires the appropriate interpreter itself.

> Not quite. The dependency chain is
> 
> plug-in -> gwyddion 'internal' module usefull externally, 
>            unfortunately not packaged as a normal perl module -> perl

Do you mean mean a perl script requires perl indirectly via modules it uses? 
Does it imply if a perl script uses no modules it does not require perl?

The direct plug-in -> perl dependency obviously exists, so listing it elsewhere
down the chain is redundant.

> Otherwise, you can simplify the spec file by having
> ...

Well, I prefer the explicit form.  Also if installed directories contain files,
I prefer

%{pkglibdir}/somedir/*
%dir %{pkglibdir}/somedir

to 

%{pkglibdir}/somedir/

as the former fails when nothing gets installed to somedir by accident while the
latter happily packages empty directory.

> Another comment, it seems to me that gwyddion-doc shouldn't own 
> %{_datadir}/gtk-doc/
> but it issems to be casually done by other packages, so it may be
> kept as is.

This surfaced on FE list more than once, but I don't recall any good solution. 
The directory is primarily owned by gtk-doc, but

  Requires: gtk-doc

is wrong because the documentation is already compiled to HTML and does not
require gtk-doc.

  Requires: %{_datadir}/gtk-doc

is wrong for the same reason (could be fixed by adding it to filesystem or a
similar base package).  So AFAIK all packages that own subdirectories of this
directory currently own it too.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.