[Bug 201149] Review Request: <Cherokee> Flexible WebServer

bugzilla at redhat.com bugzilla at redhat.com
Sun Sep 10 15:12:50 UTC 2006


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: <Cherokee> Flexible WebServer
Alias: Cherokee

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=201149





------- Additional Comments From jpmahowald at gmail.com  2006-09-10 11:12 EST -------
The spec file srpm seems to be different than that link. Oh well, I built
cherokee-0.5.4-22.1.src.rpm and:

- It does not build. Missing flex.
- When it does build the configure summary shows it missing tls and openssl. I
think those would be useful.
To fix these add a BuildRequires: flex openssl-devel gnutls-devel pkgconfig

- Your files section is missing a defattr line.
- Package owns some standard already existing directories and should not, like
/usr/share/doc /usr/share/man.  This is a result of the * wildcard
%{_datadir}/*. Explicitly list what's under %_datadir.

- The cherokee package contains development files like headers and static files,
pkgconfig file, aclocal macros, and unversioned .so files. Split these off into
a devel subpackage.
- Contains .la files. Remove these if possible.

- Missing a %changelog section. Please create one and make a new entry and
increase the version or release every time you make a spec change.

Does it have an init script that could be dropped in /etc/init.d ?

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.
You are on the CC list for the bug, or are watching someone who is.




More information about the Fedora-package-review mailing list