[Bug 205138] Review Request: libjingle - GoogleTalk implementation of Jingle

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: libjingle - GoogleTalk implementation of Jingle


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=205138


paul at all-the-johnsons.co.uk changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
OtherBugsDependingO|163778                      |163779
              nThis|                            |




------- Additional Comments From paul at all-the-johnsons.co.uk  2006-09-10 11:19 EST -------
Review

Good

Consistent use of macros
Software compiles happily in mock with no errors in rpmlint
Installs fine
Spec in US English and UTF-8
No permissions problems
No dupes in the rpms
Upstream tarball matches dist tarball md5
Includes documentation
No .a or .la files in the rpms

Minor - not a blocker, but it makes things easier on the eye
%{_libdir}/pkgconfig/jinglebase-0.3.pc
%{_libdir}/pkgconfig/jinglep2p-0.3.pc
%{_libdir}/pkgconfig/jinglesession-0.3.pc
%{_libdir}/pkgconfig/jinglexmllite-0.3.pc
%{_libdir}/pkgconfig/jinglexmpp-0.3.pc

Can be globbed - %{_libdir}/pkgconfig/jingle*.pc

I'm unable to test the code with anything extensive, but a simple bit of C
showed that it would link and do as it's told.

APPROVED

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.