[Bug 189195] Review Request: horde - php application framework

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: horde - php application framework


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=189195





------- Additional Comments From fedora at theholbrooks.org  2006-09-11 01:00 EST -------
Spec URL: http://theholbrooks.org/RPMS/horde.spec
SRPM URL: http://theholbrooks.org/RPMS/horde-3.1.3-3.src.rpm

Bumped to 3.1.3, updated Requires:, properly tag %doc files.

rpmlint is not kind to my noarch.rpm.  IMO, all of them relating to /etc/horde
can be ignored, including non-standard-[gu]id and non-standard file/dir
permissions.  The *.dist files are %config, but also IMO replacable as new
config directives may trickle down from upstream and can then be compared
against the REAL *.php config files.  The rest seems like leftover cruft from
the way the files were packaged upstream.  It it our responsibility to run some
obligatory chmod()s before the files get packaged?  I set the final permissions
for all relevant files during %install...

Thanks for the comments Chris, cryptic as they may be.  By 'updating with the
Requires', I assume you meant 'rename php-pear-Mail_Mime to php-pear-Mail-Mime',
which I've done.  Sadly I'm not sure what you could mean by 'obviously does not
handle locales properly'...  this is my first encounter with locale-aware
software, and I haven't found any documentation for %find_lang that I can use. 
Can you be more specific with what this package needs to do differently to avoid
'obviously not handle locales properly', or at least the name of a package that
handles locales in a fashion similar to what horde needs?  From my Comment #2
that was never answered:

>> 
>> * the 'locale/*/horde.mo' files should be annotated with the corresponding
>>   %lang() tags; it would be probably the best to move them to the
>>   %regular /usr/share/locale and run '%find_lang horde'
>
>I've done the first part, labeled all the locales with the %lang() macro, but
>I'm not sure if %find_lang applied in this situation.  All the horde locales
>are specified as ar_SY, bg_BG, en_US, etc... but most of the locales in
>/usr/share/locale is just the 2-letter ar, bg, en, etc.  Is find_lang smart
>enough to overcome this, should I run some logic to figure it out myself, or
>should they be copied in as-is? 

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.