[Bug 205912] Review Request: Thunar - Thunar File Manager

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: Thunar - Thunar File Manager


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=205912





------- Additional Comments From pertusus at free.fr  2006-09-11 04:43 EST -------
Some BR missing:

freetype-devel
libxslt or %{_bindir}/xsltproc

this shouldn't be used, but is safer (assorted with --enable-xml2po):
gnome-doc-utils or %{_bindir}/xml2po

A 
BuildRequires: pkgconfig
could also be there, although it should be allready needed 
by some devel dependencies.


The trash panel applet isn't built on devel, I think it is because
there is no libxfce4panel-1.0.pc providing version 4.3.90, but instead
xfce4-panel-1.0.pc with 4.2.x. This seems to be a dependency for the
xfce beta repo? At the same time it seems that the latest exo isn't
in the beta repo, so Thunar becomes a bit hard to test...

In the mean time, maybe it is better not to build  the tpa plugin, and
enable it only when xfce4-panel is updated.

There is also, for -devel, a missing
Requires: pkgconfig

in files
%{_sysconfdir}/xdg/Thunar
should be
%dir %{_sysconfdir}/xdg/Thunar

It is not completly obvious whether Gconf is usefull or not. If
it is not usefull anymore it should be removed from  
configure.ac and thunar-vfs/Makefile.am, other wise there
should certainly be a BuildRequires.

I think that it would be nice to have the gtk-doc documentation
in -devel with --enable-gtk-doc and
BuildRequires: gtk-doc

As a side note, maybe you could consider packaging 
xfce4-dev-tools
from xfce4 beta, even before xfce4 is out, since some autoconf 
macros used by Thunar are in this packages (and not in thunar).

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.