[Bug 204954] Review Request: libofa - Open Fingerprint Architecture library

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: libofa - Open Fingerprint Architecture library


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=204954





------- Additional Comments From mtasaka at ioa.s.u-tokyo.ac.jp  2006-09-12 02:36 EST -------
Okay. I will review this package.

First review:

1. From http://fedoraproject.org/wiki/Packaging/Guidelines :
* rpmlint
  - is not silent.
    W: libofa wrong-file-end-of-line-encoding /usr/share/doc/libofa-0.9.3/README
    - The following files have wrong (Windows-like) end-of-line
      encoding.

libofa-0.9.3-3.fc6/libofa-0.9.3-gcc41.patch
libofa-0.9.3-3.fc6/usr/share/doc/libofa-0.9.3/README
libofa-debuginfo-0.9.3-3.fc6/usr/src/debug/libofa-0.9.3/lib/AFLIB/aflibConverter.cpp
libofa-debuginfo-0.9.3-3.fc6/usr/src/debug/libofa-0.9.3/lib/AFLIB/aflibConverter.h
libofa-debuginfo-0.9.3-3.fc6/usr/src/debug/libofa-0.9.3/lib/AFLIB/aflibConverterLargeFilter.h
libofa-debuginfo-0.9.3-3.fc6/usr/src/debug/libofa-0.9.3/lib/AFLIB/aflibConverterSmallFilter.h
libofa-debuginfo-0.9.3-3.fc6/usr/src/debug/libofa-0.9.3/lib/JAMA/jama_svd.h
libofa-debuginfo-0.9.3-3.fc6/usr/src/debug/libofa-0.9.3/lib/JAMA/tnt_array1d.h
libofa-debuginfo-0.9.3-3.fc6/usr/src/debug/libofa-0.9.3/lib/JAMA/tnt_array2d.h
libofa-debuginfo-0.9.3-3.fc6/usr/src/debug/libofa-0.9.3/lib/JAMA/tnt_math_utils.h
libofa-debuginfo-0.9.3-3.fc6/usr/src/debug/libofa-0.9.3/lib/fft_op.cpp
libofa-debuginfo-0.9.3-3.fc6/usr/src/debug/libofa-0.9.3/lib/fftlibw3_op.cpp
libofa-debuginfo-0.9.3-3.fc6/usr/src/debug/libofa-0.9.3/lib/frametracker_op.cpp
libofa-debuginfo-0.9.3-3.fc6/usr/src/debug/libofa-0.9.3/lib/frametracker_op.h
libofa-debuginfo-0.9.3-3.fc6/usr/src/debug/libofa-0.9.3/lib/trackdata_op.cpp
libofa-debuginfo-0.9.3-3.fc6/usr/src/debug/libofa-0.9.3/lib/trackdata_op.h
libofa-debuginfo-0.9.3-3.fc6/usr/src/debug/libofa-0.9.3/lib/trackframe_op.cpp
libofa-debuginfo-0.9.3-3.fc6/usr/src/debug/libofa-0.9.3/lib/trackframe_op.h
libofa-debuginfo-0.9.3-3.fc6/usr/src/debug/libofa-0.9.3/lib/tracklist_op.cpp
libofa-debuginfo-0.9.3-3.fc6/usr/src/debug/libofa-0.9.3/lib/tracklist_op.h
libofa-devel-0.9.3-3.fc6/usr/include/ofa1/ofa.h

    W: libofa mixed-use-of-spaces-and-tabs (this is srpm)
    W: libofa-devel no-documentation (ignored)

* Requires:
  - Requires for -devel package cannot be supplied automatically, which must be
found by
  manual check.
  libofa-devel-0.9.3-3.fc6/usr/lib/pkgconfig/libofa.pc says:

Requires: fftw3
Libs: -L${libdir} -lofa -lexpat -lm
Cflags: -I${includedir}

  This means that libofa-devel requires fftw3-devel, expat-devel (and
  libofa).

 2. From http://fedoraproject.org/wiki/Packaging/ReviewGuidelines :
* MUST: The sources used to build the package....
  Umm? I cannot find Source0. I can find .tar.gz.

3. Other things I have noticed:
   = Nothing.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.