[Bug 205300] Review Request: gtk-sharp - a set of mono bindings for gtk1.2

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: gtk-sharp - a set of mono bindings for gtk1.2


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=205300





------- Additional Comments From kevin at tummy.com  2006-09-12 21:20 EST -------
Per the conversation on IRC, I'll go ahead and move this review forward...

OK - Package name
OK - Spec file matches base package name.
OK - Meets Packaging Guidelines.
OK - License (LGPL)
OK - License field in spec matches
OK - License file included in package
OK - Spec in American English
OK - Spec is legible.
See below - Sources match upstream md5sum:
Pending - Package compiles and builds on at least one arch.
Pending - BuildRequires correct
Pending - Package owns all the directories it creates.
OK - Package has no duplicate files in %files.
OK - Package has %defattr and permissions on files is good.
OK - Package has a correct %clean section.
OK - Spec has consistant macro usage.
OK - Package is code or permissible content.
OK - Packages %doc files don't affect runtime.
OK - .pc files in -devel subpackage.
OK - -devel package Requires: %{name} = %{version}-%{release}
Pending - Package doesn't own any directories other packages own.
Pending - No rpmlint output.

SHOULD Items:

OK - Should include License or ask upstream to include it.
See below - Should build in mock.
OK - Should have subpackages require base package with fully versioned depend.

Issues:

1. I can't seem to find the source download for this version.
http://sourceforge.net/project/showfiles.php?group_id=40240
has 1.0.8 as the latest stable version.
Where can this source be found?

2. Might include AUTHORS and HACKING and README.generator files?

3. Still doesn't seem to build for me in mock/devel:

Patch #0 (gtksharp-libdir.patch):
+ patch -p1 -b --suffix .libdir -s
+ autoreconf
configure.in:50: error: possibly undefined macro: PKG_PATH
      If this token and others are legitimate, please use m4_pattern_allow.
      See the Autoconf documentation.
autoreconf: /usr/bin/autoconf failed with exit status: 1
error: Bad exit status from /var/tmp/rpm-tmp.14789 (%prep)

Are you sure you have the most recent spec up (-7?)


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.