[Bug 203520] Review Request: evolution-brutus

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: evolution-brutus
Alias: evolution-brutus

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=203520





------- Additional Comments From colding at omesc.com  2006-09-13 06:08 EST -------
(In reply to comment #30)
> --------------------------------------------------
> I cannot sponsor you because I am not a member of
> sponsors. I can do only pre-review of this package.
> --------------------------------------------------
> 
> * Well, another unowned directory is found:
>   /usr/include/brutusd-1.0/

OK, fixed.


> * Well, "2.8" tag is actually related with evolution version.
>   configure says:
> 
> GETTEXT_PACKAGE=evolution-brutus-${EVOLUTION_VERSION}
> 
>   and po/Makefile.in.in says:
> 
> echo "installing $$lang.gmo as $$dir/$(GETTEXT_PACKAGE).mo"
> 
>   So, the line %{find_lang} %{name}-2.8 should be changed according
>   to the version of evolution. If this src.rpm is supposed to be
>   used both on FC6-devel and FC5, then the suffix of "2.8" must be
>   automatically changed. One way to do this is:
> 
> --------------------------------------------------------
> for f in %{_bindir}/evolution-* ; do
>    evover=${f#%{_bindir}/evolution-}
> done
> 
> %{find_lang} %{name}-${evover}
> ---------------------------------------------------------
>   With applying this, the version-specific conflict for evolution can be
>   removed.

Well, I really did not intent this SRPM to be used on anything but FC6(-devel),
as FC4/5 SRPMs are automatically generated by my build script, but your solution
is so elegant and clever that I simply *must* use it. Thanks a lot!

New files here:

Spec URL:
http://www.omesc.com/content/downloads/dist/Fedora%20Core%206/SPECS/evolution-brutus.spec
SRPM URL:
http://www.omesc.com/content/downloads/dist/Fedora%20Core%206/SRPMS/evolution-brutus-1.1.6-10.src.rpm
 
Thanks,
  jules



-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.