[Bug 200436] Review Request: gaim-gadugadu - Gadu-Gadu support in Gaim IM client

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: gaim-gadugadu - Gadu-Gadu support in Gaim IM client


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=200436


mr.ecik at gmail.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|bugzilla-sink at leemhuis.info |mr.ecik at gmail.com
OtherBugsDependingO|163776                      |163778
              nThis|                            |




------- Additional Comments From mr.ecik at gmail.com  2006-09-13 12:49 EST -------
Okay, I'll review it:

MUST items:
 * rpmlint output:
W: gaim-gadugadu incoherent-version-in-changelog 2:2.0.0-0.8.beta3.1 2.0.0-
0.8.beta3
W: gaim-gadugadu no-documentation
 * package is named well
 * spec file name is good
 * package meets Packaging Guidelines
 * package is licensed with GPL license
 * License field matches the actual license
 * license is not included in %doc (see THINGS to do)
 * md5sums of sources are matching
 * spec file is legible and is written in American English
 * package successfully compile on x86_64
 * build dependencies...?
 * no locales
 * package has good %post and %postun sections
 * not relocatable
 * package doesn't own any directories
 * no duplicates in %files
 * permissions are set properly
 * package has proper %clean section
 * package handles macros well
 * no need to -doc subpackage
 * no need to -devel subpackage
 * no .pc files
 * .la libtool archives excluded properly


THINGS to do:
 * change version in changelog entry
 * add some documentation (at least COPYING)

and mock builds fine.
Just fix things mentioned above and I'll approve it.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.