[Bug 196101] Review Request: mimedefang

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: mimedefang


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=196101





------- Additional Comments From tibbs at math.uh.edu  2006-09-16 00:28 EST -------
There seems to be something resembling tests in the "tests" directory, but I
don't see how you would actually run them.  I think you actually have to set up
the system with the test filter and then send the test messages through it,
which wouldn't be doable in an rpm.

It looks like RPM's automatic Perl dependency generation gets confused and comes
up with duplicated dependencies for perl(Digest::SHA1) and perl(MIME::Tools)
with different versioning requirements.  Unfortunately these will need to be
filtered.

Review:
* source files match upstream:
   e55b22dda54c4a3b52e1fbeb9135b0cf  mimedefang-2.57.tar.gz
* package meets naming and packaging guidelines.
* specfile is properly named, is cleanly written and uses macros consistently.
* dist tag is present.
* build root is correct.
* license field matches the actual license.
* license is open source-compatible.  License text included in package.
* latest version is being packaged.
* BuildRequires are proper.
* compiler flags are appropriate.
* %clean is present.
* package builds in mock (development, x86_64).
* package installs properly
* debuginfo package looks complete.
* rpmlint has only ignorable errors.
X final provides and requires are sane:
   config(mimedefang) = 2.57-3.fc6
   mimedefang = 2.57-3.fc6
  =
   /bin/bash
   /bin/sh
   /sbin/chkconfig
   /sbin/service
   /usr/bin/perl
   /usr/sbin/useradd
   config(mimedefang) = 2.57-3.fc6
   libperl.so()(64bit)
   perl >= 0:5.001
X  perl(Digest::SHA1)
   perl(Digest::SHA1) >= 2.00
   perl(Getopt::Std)
   perl(IO::Handle)
   perl(IO::Select)
   perl(IO::Socket)
   perl(IO::Stringy) >= 1.212
   perl(MIME::Base64) >= 3.03
   perl(MIME::Parser)
X  perl(MIME::Tools) >= 5.410
   perl(MIME::Tools) >= 5.413
   perl(MIME::Words)
   perl(Mail::SpamAssassin) >= 1.6
   perl(POSIX)
   perl(Socket)
   perl(Sys::Hostname)
   perl(Sys::Syslog)
   perl(Time::Local)
   perl(lib)
   perl(strict)
   perl(vars)
   perl(warnings)
   perl-MailTools >= 1.15
   sendmail-cf >= 8.12.0
* %check is not present; running test suite not feasible within rpmbuild.
* no shared libraries are added to the regular linker search paths.
* package is not relocatable.
* owns the directories it creates.
* doesn't own any directories it shouldn't.
* no duplicates in %files.
* file permissions are appropriate.
* scriptlets are OK (adding a service and controlling the daemon)
* code, not content.
* documentation is small, so no -docs subpackage is necessary.
* %docs are not necessary for the proper functioning of the package.
* no headers.
* no pkgconfig files.
* no libtool .la droppings.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.