[Bug 205912] Review Request: Thunar - Thunar File Manager

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: Thunar - Thunar File Manager


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=205912


pertusus at free.fr changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
OtherBugsDependingO|163778                      |163779
              nThis|                            |




------- Additional Comments From kevin at tummy.com  2006-09-15 21:12 EST -------
ok, new version: 

* Fri Sep 15 2006 Kevin Fenzi <kevin at tummy.com> - 0.4.0-0.4.rc1
- Added Requires: exo-devel >= 0.3.1.10 to devel. 
- exclude docs moved from datadir to docs
- Fixed datdir including files twice

Spec: http://www.scrye.com/~kevin/extras/Thunar/Thunar.spec
Srpm: http://www.scrye.com/~kevin/extras/Thunar/Thunar-0.4.0-0.4.rc1.fc6.src.rpm

------- Additional Comments From pertusus at free.fr  2006-09-16 06:58 EST -------
There is still an issue, in %files
%{_datadir}/Thunar/sendto/thunar-sendto-email.desktop
is listed twice...

Otherwise
* rpmlint is silent
* free software licence, included
* named according to guidelines
* follow packaging guidelines
* specfile legible
* sane provides
Provides: config(Thunar) = 0.4.0-0.4.rc1 libthunar-vfs-1.so.2 libthunarx-1.so.2
thunar-apr.so thunar-sbr.so thunar-uca.so
* source match upstream
b07ae97a69964112e0af84ba2f63585d  Thunar-0.4.0rc1.tar.bz2
* libs packaged correctly
* docs not used at runtime
* desktop files present and following guidelines
* build and work in devel
* own all directories
* no file included twice
* %files right except for a typo

APPROVED
if you fix the file included twice.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.