[Bug 201006] Review Request: HelixPlayer

bugzilla at redhat.com bugzilla at redhat.com
Tue Sep 19 14:34:56 UTC 2006


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: HelixPlayer


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=201006





------- Additional Comments From gauret at free.fr  2006-09-19 10:34 EST -------
Michael, I've read that you have many other things to do at the moment, so
here's my take at the modifications :
http://gauret.free.fr/fichiers/rpms/fedora/HelixPlayer.spec
And the diffs : http://gauret.free.fr/fichiers/rpms/fedora/HelixPlayer.diff

I did not manage to make the build system obey $RPM_OPT_FLAGS, this build system
is much too complicated for me (and it does not look at the env vars).

I think the rest is fixed (except the mixed-use-of-spaces-and-tabs, it's wrong,
there is only tabs to indent)

Michael, if you like the changes, just use them, and HelixPlayer will be good to
import as far as I'm concerned.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.




More information about the Fedora-package-review mailing list