[Bug 201149] Review Request: <Cherokee> Flexible WebServer

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: <Cherokee> Flexible WebServer
Alias: Cherokee

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=201149


opensource at till.name changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |opensource at till.name




------- Additional Comments From opensource at till.name  2006-09-21 18:45 EST -------
I just took a look into http://manuel.todo-linux.com/cherokee/spec/cherokee.spec
and there is a lot that should be fixed. Please read
http://fedoraproject.org/wiki/Packaging/Guidelines

%configure already sets these options:
--prefix=%{_prefix}         \
            --sysconfdir=%{_sysconfdir} \
            --mandir=%{_mandir}         \
            --sbindir=%{_sbindir}       \
So they are not needed here. (see rpm --eval "%configure")
%configure also sets CFLAGS="$RPM_OPT_FLAGS"
So you should set CFLAGS="-O0 -g3" before the invocation of %configure to make
sure that $RPM_OPT_FLAGS are honourd. Do you really need debug level 3 and no
optimization?

Why are these commands in %post?
ln -s %{_sysconfdir}/cherokee/sites-available/default \
      %{_sysconfdir}/cherokee/sites-enabled/default
mkdir -p /home/httpd

The COPYING file is missing

There is an unneeded Source:, since there is already Source0:

Why is there still a Docdir Tag?

Why don't you use %{?dist} in the release?

The %changelog is still empty.






-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.
You are on the CC list for the bug, or are watching someone who is.