[Bug 173459] Review Request: initng

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: initng


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=173459


enrico.scholz at informatik.tu-chemnitz.de changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|nobody at fedoraproject.org    |enrico.scholz at informatik.tu-
                   |                            |chemnitz.de
OtherBugsDependingO|163776                      |163778
              nThis|                            |




------- Additional Comments From enrico.scholz at informatik.tu-chemnitz.de  2006-09-22 14:28 EST -------
initng + initng-ifiles
----------------------

GOOD:

* package follows naming guidelines
* spec-file name is ok
* I do not see a violation of packaging guidelines; it builds in mock
  and BuildRequires: are satisfying
* license is ok and consistent
* COPYING is shipped in package
* I do not see a violation of Americon English (does not mean very
  much...;) )
* spec-file is ok
* builds on i386
* package does not have locales which must be handled
* scripts of -lib are calling 'ldconfig'
* package owns all used directories resp. they are shipped by a
  dependency (except of the man-dir but this is accepted)
* %clean section is ok
* paths are macro'ized as far as possible; special paths like /boot or
  /sbin must be written literarily
* content is ok
* documentation is ok
* headers/.so are in -lib
* no pkgconfig issues
* inter-(sub)package dependencies are ok
* there are no .la archives
* no desktop files needed and shipped


initng
------

BLOCKER:

* permissions of plugins are bad; rpmlint complains with

  | W: initng unstripped-binary-or-object /lib/initng/libunneeded.so
  | W: initng unstripped-binary-or-object /lib/initng/libsysreq.so

  like messages. You should add 'chmod +x /%_lib/initng/*.so'



initng-ifiles
-------------

BLOCKER:

* fail to build:
  | [  0%] Building C object tools/CMakeFiles/install_service.dir/install_service.o
  | distcc[3688] ERROR: compile (null) on localhost failed
  | /var/tmp/sessiondir-ensc.1158090336.eM4348/redhat/BUILD/initng-ifiles-0.0.6/tools/install_service.c:34:26: error: initng-paths.h: No such file or directory
  | /var/tmp/sessiondir-ensc.1158090336.eM4348/redhat/BUILD/initng-ifiles-0.0.6/tools/install_service.c:73: error: 'INITNG_PLUGIN_DIR' undeclared here (not in a function)
  | distcc[3687] ERROR: compile /var/tmp/sessiondir-ensc.1158090336.eM4348/redhat/BUILD/initng-ifiles-0.0.6/tools/install_service.c on localhost failed

  Probably an issue in 'initng' (unverified).

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.