[Bug 207082] Review Request: perl-Feed-Find - Syndication feed auto-discovery

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: perl-Feed-Find - Syndication feed auto-discovery


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=207082


tibbs at math.uh.edu changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|nobody at fedoraproject.org    |tibbs at math.uh.edu
OtherBugsDependingO|163776                      |163779
              nThis|                            |




------- Additional Comments From tibbs at math.uh.edu  2006-09-22 21:30 EST -------
This fails to build for me:

t/01-find.......
#   Failed test in t/01-find.t at line 13.
#          got: '0'
#     expected: '1'

#   Failed test in t/01-find.t at line 14.
#          got: undef
#     expected: 'http://stupidfool.org/perl/feeds/ok.xml'

#   Failed test in t/01-find.t at line 20.
#          got: '0'
#     expected: '1'

#   Failed test in t/01-find.t at line 21.
#          got: undef
#     expected: 'http://stupidfool.org/perl/feeds/ok.xml'
# Looks like you failed 4 tests of 4.
dubious
        Test returned status 4 (wstat 1024, 0x400)
DIED. FAILED tests 1-4
        Failed 4/4 tests, 0.00% okay
Failed Test Stat Wstat Total Fail  Failed  List of Failed
-------------------------------------------------------------------------------
t/01-find.t    4  1024     4    4 100.00%  1-4
Failed 1/2 test scripts, 50.00% okay. 4/5 subtests failed, 20.00% okay.

I doubt this test will ever work in mock.  I think you need "rm t/01-find.t" in
%check (or in %prep if you want to avoid a complaint about a missing test) with
suitable comments to indicate why it's being disabled.

That done, things build OK.

I'll assume that change is done for the purposes of this review.
* source files match upstream:
   be4537f652d41243cbf98f5e937d16f3  Feed-Find-0.06.tar.gz
* package meets naming and packaging guidelines.
* specfile is properly named, is cleanly written and uses macros consistently.
* dist tag is present.
* build root is correct.
* license field matches the actual license.
* license is open source-compatible.  License text not included upstream.
* latest version is being packaged.
O BuildRequires are proper (BR: perl is unnecessary, and perl(LWP::UserAgent) is
redundant).
* %clean is present.
* package builds in mock (development, x86_64).
* package installs properly
* rpmlint is silent.
* final provides and requires are sane:
   perl(Feed::Find) = 0.06
   perl-Feed-Find = 0.06-1.fc6
  =
   perl(:MODULE_COMPAT_5.8.8)
   perl(Class::ErrorHandler)
   perl(HTML::Parser)
   perl(LWP::UserAgent)
   perl(URI)
   perl(base)
   perl(constant)
   perl(strict)
   perl(vars)
* %check is present and all tests pass:
   All tests successful.
   Files=1, Tests=1,  0 wallclock secs ( 0.04 cusr +  0.01 csys =  0.05 CPU)
* package is not relocatable.
* owns the directories it creates.
* doesn't own any directories it shouldn't.
* no duplicates in %files.
* file permissions are appropriate.
* no scriptlets present.
* code, not content.
* documentation is small, so no -docs subpackage is necessary.
* %docs are not necessary for the proper functioning of the package.

APPROVED, provided the non-runnable test is removed so that things build in mock.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.