[Bug 207313] Review Request: php-pear-PHP-Compat - Provides missing functionality for older versions of PHP
bugzilla at redhat.com
bugzilla at redhat.com
Sat Sep 23 14:47:01 UTC 2006
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: php-pear-PHP-Compat - Provides missing functionality for older versions of PHP
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=207313
tibbs at math.uh.edu changed:
What |Removed |Added
----------------------------------------------------------------------------
OtherBugsDependingO|163778 |163779
nThis| |
------- Additional Comments From tibbs at math.uh.edu 2006-09-23 10:46 EST -------
* source files match upstream:
4d73c451f4f3a8f9a0516bd26af7f652 PHP_Compat-1.5.0.tgz
* package meets naming and packaging guidelines.
* specfile is properly named, is cleanly written and uses macros consistently.
* dist tag is present.
* build root is correct.
* license field matches the actual license.
* license is open source-compatible. License text included in package.
* latest version is being packaged.
* BuildRequires are proper.
* %clean is present.
* package builds in mock (development, x86_64).
* package installs properly
* rpmlint is silent (except for the usual bogus "dangerous-command" warning).
* final provides and requires are sane:
php-pear(PHP_Compat) = 1.5.0
php-pear-PHP-Compat = 1.5.0-1.fc6
=
/bin/sh
/usr/bin/pear
php-pear(PEAR)
* %check is present, but tests the packaging, not the package. There are tests
for the package, but as with all PEAR modules it's not really possible to run
them at build time.
* package is not relocatable.
* owns the directories it creates.
* doesn't own any directories it shouldn't.
* no duplicates in %files.
* file permissions are appropriate.
* no scriptlets present.
* code, not content.
* documentation is small, so no -docs subpackage is necessary.
* %docs are not necessary for the proper functioning of the package.
APPROVED
--
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.
More information about the Fedora-package-review
mailing list