[Bug 207796] Review Request: eventlog - Syslog-ng v2 support library

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: eventlog - Syslog-ng v2 support library


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=207796


tibbs at math.uh.edu changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
OtherBugsDependingO|163778                      |163779
              nThis|                            |




------- Additional Comments From tibbs at math.uh.edu  2006-09-23 13:50 EST -------
It's not necessary to have:
   Requires(post): /sbin/ldconfig
   Requires(postun): /sbin/ldconfig
since you are using the 
  %post -p /sbin/ldconfig
form for your scriptlets.  Not a blocker, of course, but /sbin/ldconfig does
show up four times in the dependency list.

* source files match upstream:
   a6bdba91f88540cc69b398fd138d86cd  eventlog-0.2.5.tar.gz
* package meets naming and packaging guidelines.
* specfile is properly named, is cleanly written and uses macros consistently.
* dist tag is present.
* build root is correct.
* license field matches the actual license.
* license is open source-compatible.  License text included in package.
* latest version is being packaged.
* BuildRequires are proper.
* compiler flags are appropriate.
* %clean is present.
* package builds in mock (development, x86_64).
* package installs properly
* debuginfo package looks complete.
* rpmlint has one acceptable warning.
* final provides and requires are sane:
  eventlog-0.2.5-1.fc6.x86_64.rpm
   libevtlog.so.0()(64bit)
   eventlog = 0.2.5-1.fc6
  =
   /sbin/ldconfig
   libevtlog.so.0()(64bit)

  eventlog-devel-0.2.5-1.fc6.x86_64.rpm
   eventlog-devel = 0.2.5-1.fc6
  =
   eventlog = 0.2.5-1.fc6
   libevtlog.so.0()(64bit)

* %check is not present; no test suite upstream
* shared libraries are added to the regular linker search paths; ldconfig called
as necessary.
* owns the directories it creates.
* doesn't own any directories it shouldn't.
* no duplicates in %files.
* file permissions are appropriate.
* scriptlets are OK (ldconfig)
* code, not content.
* documentation is small, so no -docs subpackage is necessary.
* %docs are not necessary for the proper functioning of the package.
* headers are in the -devel subpackage.
* pkgconfig file is in the -devel subpackage.
* static libraries and unversioned .so files are in the -devel subpackage.
* static libraries are acceptable in this instance.
* no libtool .la droppings.

APPROVED

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.