[Bug 207761] Review Request: xpdf - A PDF file viewer for the X Window System
bugzilla at redhat.com
bugzilla at redhat.com
Sat Sep 23 20:11:01 UTC 2006
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: xpdf - A PDF file viewer for the X Window System
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=207761
------- Additional Comments From pertusus at free.fr 2006-09-23 16:10 EST -------
More issues:
* $RPM_BUILD_ROOT/etc/X11/applnk/Graphics seems to be unneeded
* removing the files should better be without -r and, in my
opinion even without f.
* /etc/xpdfrc in %files should be %{_sysconfdir}. And it should
also be nice to have a sed on all the files mentionning
/etc/xpdfrc substituted by the patches.
Something along
for file in doc/*.1 doc/*.5 xpdf-*/README; do
sed -i -e 's:/etc/xpdfrc:%{_sysconfdir}/xpdfrc:g'
done
* similarly /usr/share in the relevant files should be changed
to %{_datadir}. Something along
for file in xpdf-*/README xpdf-*/add-to-xpdfrc; do
sed -i -e 's:/usr/share/:%{_datadir}/:g'
done
* All the README files that are in /usr/share/xpdf/LANG/README
should be in %doc, and I propose to have for them the
name README.LANG for each LANG.
* The add-to-xpdfrc files should certainly be marked as %config.
Also it is not obvious that these files are rightly in
/usr/share/xpdf/LANG/. In my opinion they should better be in
/etc. What I would suggest would be to add the directory
%{_sysconfdir}/xpdf/
and put the add-to-xpdfrc within subdirectories one for each
language, or, if you prefer otherwise, something similar.
xpdf-3.01-redhat.patch should then be updated (the part corresponding
with xpdf-3.00/doc/sample-xpdfrc).
--
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.
More information about the Fedora-package-review
mailing list